Clean-up typing_extensions after support dropped for older Pythons
#892
Conversation
typing_extensions after support dropped older Pythonstyping_extensions after support dropped for older Pythons
|
Rebased onto latest master after #893 |
JelleZijlstra
left a comment
There was a problem hiding this comment.
Thanks for all this work!
This looks good, but I'll want to check manually that 3.6.0 and 3.6.1 still work since they're not covered by CI.
CONTRIBUTING.md
Outdated
| Python 2.7 and 3.4. However, it is OK to omit support for Python versions that have | ||
| `typing_extensions` supports Python 3.6+. However, it is OK to omit support for Python versions that have | ||
| reached end of life if doing so is too difficult or otherwise does not make sense. For | ||
| example, `typing_extensions.AsyncGenerator` only exists on Python 3.6 and higher, |
There was a problem hiding this comment.
This example doesn't make sense any more because only 3.6+ are supported. Maybe we can recast it to say something like "Back when we still supported 3.5, AsyncGenerator was only available in 3.6+"
There was a problem hiding this comment.
Updated to "For example, typing_extensions.AsyncGenerator was only supported in Python 3.6 and newer, because async generators were not part of the language before then."
A
There was a problem hiding this comment.
You could also phrase in the negative -- e.g. "For example, typing_extensions.AsyncGenerator was not supported in Python versions before 3.6, as async generators were not part of the language."
I checked 3.6.0, but not 3.6.1 -- although I think I covered all the edge cases for changes between micro versions. A |
|
|
||
| if HAVE_PROTOCOLS: | ||
| __all__.extend(['Protocol', 'runtime', 'runtime_checkable']) | ||
| __all__.extend(['Annotated', 'Protocol', 'runtime', 'runtime_checkable']) |
There was a problem hiding this comment.
Given these names are now unconditionally added to __all__, I think they should be in the initial definition -- but not sure in which category to put them
A
|
I'm sorry that there hasn't been any feedback lately. Part of it is that I didn't yet have time to fully review the changes in the src dir, part that I wasn't sure how to best proceed, considering our lack of a clear versioning policy. I have opened python/typing_extensions#32 to clear the latter up. |
|
Thanks Sebastian If I could do anything to ease the review, happy to help. Also happy to wait until the versioning policy has been clarified. A |
|
And sorry again. Could you maybe split this into two PRs: One with the changes to typing_extensions and one with the "meta" changes for the build process? I had already reviewed the meta changes and then didn't find the time to continue with the lib. Splitting it would be easier. |
|
Done @srittau |
|
@AA-Turner: Thanks for splitting! Is this PR still relevant or can it be closed? |
|
No, closing. Thanks! |
@hauntsaninja noted that a PR would likely be welcome, so opening here.
xref #867, #867 (comment)
A