Skip to content

Fix and clean up CI script #876

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
JelleZijlstra merged 10 commits into from
Aug 31, 2021
Merged

Fix and clean up CI script #876

JelleZijlstra merged 10 commits into from
Aug 31, 2021

Conversation

@srittau
Copy link
Collaborator

@srittau srittau commented Aug 30, 2021 •
edited
Loading

  • Split Python 2.7 tests from Python 3 tests as they use different paths and require installation of the typing module.
  • Split typing backport and typing_extension tests for Python 2.
  • Install typing from pypi instead of using the local version for Python 2.
  • Remove support for Python 3.4 and 3.5.
  • Don't run typing backport tests for Python 3.
  • Unpin pytest version for Python 3.
  • Don't install unnecessary pytest plugins pytest-xdist and pytest-cov.

@srittau
Clean up CI script
a6b5de3 
* Split Python 2.7 tests from Python 3 tests as they use different paths
  and require installation of the typing module.
* Split running typing and typing_extensions tests into two steps.
* Run the typing test step only on Python < 3.7.
JelleZijlstra
JelleZijlstra reviewed Aug 30, 2021
View reviewed changes
@srittau srittau marked this pull request as ready for review August 30, 2021 22:24
@srittau
Copy link
Collaborator Author

srittau commented Aug 30, 2021

Ready for review. I'm unsure why the 3.10 fails, but at least the CI script is now cleaner, and it fails in a test that it should actually run, not in the typing test, so this PR is an improvement. I will have another stab at this tomorrow, if no one beats me to it.

@JelleZijlstra
Copy link
Member

JelleZijlstra commented Aug 30, 2021

Might be an incompatibility in pytest or pytest-xdist. To get around it we could just stick to unittest.

@srittau
Update pytest dependencies
34eda40 
* Pin version only for Python 2
* Remove pytest-xdist and pytest-cov not necessary here
@sondrelg sondrelg mentioned this pull request Aug 31, 2021
Merged
@srittau srittau changed the title Clean up CI script Fix and clean up CI script Aug 31, 2021
@srittau srittau mentioned this pull request Aug 31, 2021
Merged
@JelleZijlstra JelleZijlstra merged commit 9f0f1b6 into python:master Aug 31, 2021
@srittau srittau deleted the fix-ci branch August 31, 2021 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra left review comments

Assignees

No one assigned

Labels

CLA signed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@srittau @JelleZijlstra @the-knights-who-say-ni