Add OrderedDict to typing_extensions#791
Conversation
This comment has been minimized.
This comment has been minimized.
gvanrossum
left a comment
There was a problem hiding this comment.
LGTM. Once your CLA comes through I'll merge it. (Click on the "check yourself" link in the comment from the CLA bot once a day and enter your GitHub username in the form to trigger the label change.)
|
Thanks, it looks like the bot updated the label Do you by any chance know why the 3.7.0 and 3.7.1 tests are failing with a metaclass conflict? I've been trying to debug it but I don't understand it. |
|
Huh, I don't. Presumably some difference between typing.py in 3.7.1 and 3.7.2 is key. You should be able to get that out of the cpython repo by comparing the code for the respective tags. (It could also be something in collections.) |
|
That looks okay -- what did you find was the problem? (In 3.7.2, which clause gets triggered?) I suppose you have to click the "Ready for review" button. |
|
I haven't figured out the metaclass conflict so on a lark I made it so that |
|
I don't know for sure, but I suspect it doesn't really matter, and it gets the tests done, so I'm okay to take the plunge with this. If you agree, just mark it as Ready for review (which I could do, but I don't want to embarrass you if you've got second thoughts). |
|
I came to the same conclusion. I think if I were to try to resolve the conflict, I would end up reimplementing the whole class and metaclass which seems like a lot of effort for two patch releases when the one-line solution works just as well. |
This PR adds OrderedDict to the typing_extensions module for Python 3 since it is not available in Python < 3.7.2