Fix jsonschema exception str|int containers#7981
Merged
AlexWaygood merged 1 commit intopython:masterfrom May 29, 2022
Merged
Conversation
schema_path, relative_schema_path, and absolute_schema_path are all (related) attributes of `jsonschema` errors which contain `str | int` but were accidentally annotated as containing `str`. Fix them for accuracy.
Contributor
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #7980, I checked for more attributes where I had made the mistake of introducing a
<container>[str]annotation which should read<container>[str | int]I didn't have an example usage in mind, so I tried adding a
for x in schema_path: assert isinstance(x, str)to the error init and running jsonschema's tests. It failed (as expected) on ints, so I'm certain that the original annotation I added has an error in it and I'm reasonably confident thatstr | intis the correct form.schema_path, relative_schema_path, and absolute_schema_path are all (related) attributes of
jsonschemaerrors which containstr | intbut were accidentally annotated as containingstr. Fix them for accuracy.