Fix stubtest for third-party mock package#6685
Merged
Akuli merged 1 commit intopython:masterfrom Dec 25, 2021
Merged
Conversation
Removed a few "Any" annotations that could be typed. (There are more.) Add package to pyrightconfig.stricter.json ignore list. Also removed a few unused private classes and methods. They can be re-added if a user reports them missing.
Akuli
reviewed
Dec 25, 2021
| # This overload also covers the case, where new==DEFAULT. In this case, self is _patch[Any]. | ||
| # Ideally we'd be able to add an overload for it so that self is _patch[MagicMock], | ||
| # but that's impossible with the current type system. | ||
| @overload |
Collaborator
There was a problem hiding this comment.
Why was the first overload removed?
Collaborator
Author
There was a problem hiding this comment.
new is a mandatory argument.
Akuli
approved these changes
Dec 25, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed a few "Any" annotations that could be typed. (There are more.) Add
package to pyrightconfig.stricter.json ignore list.
Also removed a few unused private classes and methods. They can be re-added
if a user reports them missing.