protobuf: Fix inadvertently deleted annotations.#3364
Merged
JelleZijlstra merged 2 commits intopython:masterfrom Oct 14, 2019
Merged
protobuf: Fix inadvertently deleted annotations.#3364JelleZijlstra merged 2 commits intopython:masterfrom
JelleZijlstra merged 2 commits intopython:masterfrom
Conversation
cbfafbd to
c67fbb5
Compare
srittau
approved these changes
Oct 14, 2019
Member
|
Unfortunately CI failed because flake8 is unhappy about the blank lines. I wouldn't mind if you just run Black on this directory for this PR if that's easiest for you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In 036abc7, I meant to delete a lot of
FromString()declarations from concreteMessagesubclasses but also deleted some nearby variable annotations. In this change, I restore the incorrectly deleted annoations.I apologize from the extra newlines in the change here. I assume everything will soon be blackened, so I didn't invest much effort in getting rid of the newlines.