Remove raise statements from function bodies#3355
Merged
srittau merged 1 commit intopython:masterfrom Oct 13, 2019
Merged
Conversation
While it may eventually be useful to mark the exceptions that can be raised from a function or method, the semantics are currently undefined and unclear.
Contributor
|
What do you think about improving the semantics instead of dropping raise statements? I'm not sure if they disturb someone. |
Collaborator
Author
|
Semantics need to be defined. This is outside the scope of typeshed. The current raise statements could contradict the proposed semantics and then be a liability. Some type checkers cold decide to experiment with raise statements. The existing annotations could interfere with that. Also, since they are currently only used by very few files, it is likely that they get outdated and won't match reality. Finally, they are not checked by any of our CI tests, so errors are likely not to be caught. |
JelleZijlstra
approved these changes
Oct 13, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While it may eventually be useful to mark the exceptions that can be
raised from a function or method, the semantics are currently undefined
and unclear.