Allow callables in _SourceObjectType (Python 2)#3338
Merged
JelleZijlstra merged 1 commit intopython:masterfrom Oct 11, 2019
The-Compiler:patch-1
Merged
Allow callables in _SourceObjectType (Python 2)#3338JelleZijlstra merged 1 commit intopython:masterfrom The-Compiler:patch-1
JelleZijlstra merged 1 commit intopython:masterfrom
The-Compiler:patch-1
Conversation
This is important because mypy doesn't generally think functions are compatible with `FunctionType`, so `inspect.getsource` on arbitrary functions is rejected by the current annotations.
JelleZijlstra
approved these changes
Oct 10, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is important because mypy doesn't generally think functions are compatible with
FunctionType, soinspect.getsourceon arbitrary functions is rejected by the current annotations.This is a port of #3295 to the Python 2 version of
inspect.pyi- thanks @JelleZijlstra for the original PR!