Update the signature of decorator.decorator#3336
Merged
JukkaL merged 1 commit intopython:masterfrom Oct 10, 2019
Merged
Conversation
Nothing prevents a decorator defined using `@decorator` from changing the signature of the decorated function. For example, this example changes the return type to `str`: ``` from decorator import decorator @decorator def stringify(f, *args, **kwargs) -> str: return str(f(*args, **kwargs)) ``` The old signature caused false positives in internal Dropbox code. I couldn't come up with a signature that would produce better types with mypy while not generating false positives.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Nothing prevents a decorator defined using
@decoratorfromchanging the signature of the decorated function. For example,
this example changes the return type to
str:The old signature caused false positives in internal Dropbox code.
I couldn't come up with a signature that would produce better types
with mypy while not generating false positives.