protobuf: Tighten annotations for MergeFromString and ParseFromString.#3333
Merged
srittau merged 1 commit intopython:masterfrom Oct 10, 2019
Merged
protobuf: Tighten annotations for MergeFromString and ParseFromString.#3333srittau merged 1 commit intopython:masterfrom
srittau merged 1 commit intopython:masterfrom
Conversation
srittau
approved these changes
Oct 10, 2019
Collaborator
srittau
left a comment
There was a problem hiding this comment.
Looks good to me, just one style nit and one question.
|
|
||
| _T = TypeVar("_T") | ||
|
|
||
| if sys.version_info[0] == 2: |
Collaborator
There was a problem hiding this comment.
Style nit: We use sys.version_info < (3,) consistently throughout typeshed.
| if sys.version_info[0] == 2: | ||
| _Serialized = Union[bytes, buffer, unicode] | ||
| else: | ||
| _Serialized = Union[bytes, memoryview] |
Collaborator
There was a problem hiding this comment.
In case this also allows bytestring, this could be simplified to just bytes, per the documentation.
87b4fea to
20dcf42
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.