Mark some urllib.parse return fields optional#3332
Merged
srittau merged 1 commit intopython:masterfrom Oct 9, 2019
rra:urlparse
Merged
Mark some urllib.parse return fields optional#3332srittau merged 1 commit intopython:masterfrom rra:urlparse
srittau merged 1 commit intopython:masterfrom
rra:urlparse
Conversation
Per the urllib.parse documentation, username, password, hostname, and port will be set to None if not set in the parsed URL. The same is true for urlparse in Python 2 according to its documentation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per the urllib.parse documentation, username, password, hostname,
and port will be set to None if not set in the parsed URL. The
same is true for urlparse in Python 2 according to its documentation.