models.pyi: Add missing requests.Respons.next()#3328
Merged
srittau merged 3 commits intopython:masterfrom Oct 9, 2019
Merged
Conversation
srittau
reviewed
Oct 9, 2019
srittau
reviewed
Oct 9, 2019
| def __enter__(self) -> Response: ... | ||
| def __exit__(self, *args: Any) -> None: ... | ||
| def next(self) -> PreparedRequest: ... | ||
| def next(self) -> None: ... |
Collaborator
There was a problem hiding this comment.
This should be Union[None, PreparedRequest] to express it can be either. A nicer way to write unions with None is to useOptional, though: Optional [PreparedRequest].
Contributor
Author
There was a problem hiding this comment.
Ah!
TIL: Optional[...] is a shorthand notation for Union[..., None]. Thanks!
srittau
approved these changes
Oct 9, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #3207