add IncrementalNewlineDecoder constructor#3311
Merged
srittau merged 3 commits intopython:masterfrom Oct 6, 2019
rmorshea:patch-1
Merged
add IncrementalNewlineDecoder constructor#3311srittau merged 3 commits intopython:masterfrom rmorshea:patch-1
srittau merged 3 commits intopython:masterfrom
rmorshea:patch-1
Conversation
IncrementalNewlineDecoder defined a new constructor because it wraps other decoders. See: https://github.com/python/cpython/blob/65dcc8a8dc41d3453fd6b987073a5f1b30c5c0fd/Lib/_pyio.py#L1886
srittau
requested changes
Oct 6, 2019
Collaborator
srittau
left a comment
There was a problem hiding this comment.
Thanks, one comment below. I don't know why pytype fails, but let's see what happens if this problem gets solved.
stdlib/3/io.pyi
Outdated
|
|
||
| class IncrementalNewlineDecoder(codecs.IncrementalDecoder): | ||
| def __init__(self, decoder: Optional[codecs.IncrementalDecoder], | ||
| translate: bool, errors: str = 'strict') -> None: ... |
Collaborator
There was a problem hiding this comment.
Default values must be .... This is also why flake8 fails.
srittau
approved these changes
Oct 6, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IncrementalNewlineDecoder defined a new constructor because it wraps other decoders.
See: https://github.com/python/cpython/blob/65dcc8a8dc41d3453fd6b987073a5f1b30c5c0fd/Lib/_pyio.py#L1886