Skip to content

Fix the signature of IOBase._checkClosed().#3305

Merged
rchen152 merged 1 commit intomasterfrom
iobase
Oct 4, 2019
Merged

Fix the signature of IOBase._checkClosed().#3305
rchen152 merged 1 commit intomasterfrom
iobase

Conversation

@rchen152
Copy link
Collaborator

@rchen152 rchen152 commented Oct 4, 2019

  • In Python 2, the optional msg argument was missing.
  • In Python 3, the method was missing altogether.

Reference:
https://github.com/python/cpython/blob/2.7/Lib/_pyio.py#L423
https://github.com/python/cpython/blob/3.6/Lib/_pyio.py#L443

* In Python 2, the optional `msg` argument was missing.
* In Python 3, the method was missing altogether.

Reference:
https://github.com/python/cpython/blob/2.7/Lib/_pyio.py#L423
https://github.com/python/cpython/blob/3.6/Lib/_pyio.py#L443
@rchen152 rchen152 merged commit 90aa27b into master Oct 4, 2019
@rchen152 rchen152 deleted the iobase branch October 4, 2019 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants