Skip to content

ssl: add VerifyFlags flags and VerifyMode enum#3302

Merged
srittau merged 1 commit intopython:masterfrom
jlaine:ssl-enums
Oct 4, 2019
Merged

ssl: add VerifyFlags flags and VerifyMode enum#3302
srittau merged 1 commit intopython:masterfrom
jlaine:ssl-enums

Conversation

@jlaine
Copy link
Contributor

@jlaine jlaine commented Oct 4, 2019

No description provided.

Copy link
Collaborator

@srittau srittau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Two things:

  • Just use one blank line, otherwise flake8 complains and the build fails.
  • For the enum values itself use VERIFY_DEFAULT: int as annotation. The stubs don't care about the actual values, but the type is not automatically inferred from the enum type.

@srittau srittau merged commit 41d23a6 into python:master Oct 4, 2019
@jlaine jlaine deleted the ssl-enums branch October 4, 2019 14:30
@jlaine
Copy link
Contributor Author

jlaine commented Oct 4, 2019

Thank you Sebastian!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants