Stubs for geoip2 third party library#3299
Closed
jolaf wants to merge 40 commits intopython:masterfrom
jolaf:geoip2
Closed
Stubs for geoip2 third party library#3299jolaf wants to merge 40 commits intopython:masterfrom jolaf:geoip2
jolaf wants to merge 40 commits intopython:masterfrom
jolaf:geoip2
Conversation
Make vars arguments Optional, as they default to None (#2853)
…e it should be Union[str, bytes] Fixes #2831
Update from upstream
Missing return values added; A lot of parameters have been made Optional, according to documentation; translation() stub improved by using @overload
Sequence replaced with Container Co-Authored-By: Sebastian Rittau <srittau@rittau.biz>
Sequence replaced with Iterable Co-Authored-By: Sebastian Rittau <srittau@rittau.biz>
Co-Authored-By: Sebastian Rittau <srittau@rittau.biz>
Merge from master
…documented but useful.
Merge from master
Merge from master
JelleZijlstra
requested changes
Oct 7, 2019
Member
JelleZijlstra
left a comment
There was a problem hiding this comment.
Thanks! I have a few minor comments.
Also, any chance these could be moved to 2and3? Probably all that is needed is to use Text instead of str.
Contributor
Author
|
Contributor
Author
|
I'm closing this in favor of #3317. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Approved by the developer, see maxmind/GeoIP2-python#70