Merged
Conversation
srittau
approved these changes
Jun 20, 2019
Collaborator
srittau
left a comment
There was a problem hiding this comment.
Thanks, one optional comment, fine to merge either way.
| def sock_sendall(self, sock: socket, data: bytes) -> Generator[Any, None, None]: ... | ||
| @coroutine | ||
| def sock_connect(self, sock: socket, address: str) -> Generator[Any, None, None]: ... | ||
| def sock_connect(self, sock: socket, address: _Address) -> Generator[Any, None, None]: ... |
Collaborator
There was a problem hiding this comment.
This method is inherited from AbstractEventLoop and not even overridden in BaseEventLoop, so it can be removed here.
Collaborator
There was a problem hiding this comment.
Hrm, my bad. While it seems that BaseEventLoop is indeed abstract, it is not marked as such. Probably easiest to re-add sock_connect().
This reverts commit 62dd9f0.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I ran into a place in our code where we pass a (host, port) tuple to sock_connect. According to https://docs.python.org/3/library/asyncio-eventloop.html#asyncio.loop.sock_connect, the address argument is the same as that to socket.connect (https://docs.python.org/3/library/socket.html#socket.socket.connect), so I use the same type alias used for socket.
socket.connect also takes bytes according to our annotations, but from my experiments it seems that asyncio's version does not.