Add types and functions in types.py that are new in 3.7#3066
Merged
JelleZijlstra merged 4 commits intopython:masterfrom Jun 19, 2019
Merged
Add types and functions in types.py that are new in 3.7#3066JelleZijlstra merged 4 commits intopython:masterfrom
JelleZijlstra merged 4 commits intopython:masterfrom
Conversation
Contributor
Author
|
I also noticed that at least one of the new types does define its own |
Collaborator
|
Generally, dunder methods should be included, except when they are already defined the same way in the superclass hierarchy. A few dunder methods like |
for `new_class` if the version is at least 3.7
Contributor
Author
|
Went and actually examined the CPython implementation for 3.7, added the implemented comparison operators. |
JelleZijlstra
approved these changes
Jun 19, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As declared in the title, this adds the types and the single new function that were added to the types.py module in Python 3.7.
Closes #3064