Update select and selectors to use _HasFileno protocol#3057
Merged
JelleZijlstra merged 1 commit intopython:masterfrom Jun 15, 2019
Eric-Arellano:selectors-protocol
Merged
Update select and selectors to use _HasFileno protocol#3057JelleZijlstra merged 1 commit intopython:masterfrom Eric-Arellano:selectors-protocol
JelleZijlstra merged 1 commit intopython:masterfrom
Eric-Arellano:selectors-protocol
Conversation
JelleZijlstra
approved these changes
Jun 15, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At the time of creating type stubs for the stdlib
select.pyiandselectors.pyi, there was no support for structural subtyping via protocols. So, the stubs had to useAny(no type safety) andsocket.socket(only a subset of supported types).Now that protocols are widely supported (https://www.python.org/dev/peps/pep-0544/ and https://mypy-lang.blogspot.com/2017/10/mypy-0530-released.html), the exact types can be expressed properly.
Here, we use the naming convention established in
faulthandler.pyi:typeshed/stdlib/3/faulthandler.pyi
Lines 5 to 6 in 1f740a7
This properly fixes #482.