Add redis stream methods to the client stubs#3051
Merged
JelleZijlstra merged 2 commits intopython:masterfrom Jun 13, 2019
Merged
Add redis stream methods to the client stubs#3051JelleZijlstra merged 2 commits intopython:masterfrom
JelleZijlstra merged 2 commits intopython:masterfrom
Conversation
JelleZijlstra
approved these changes
Jun 12, 2019
Member
JelleZijlstra
left a comment
There was a problem hiding this comment.
Looks good. Would be good to also add some types though.
Contributor
Author
|
I would be keen to do a followup PR to add some typing to the redis stubs. I think this PR is still useful as it is - it will stop the false positive errors when using the stream functionality. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3050