Skip to content

message.pyi: Now takes Address as EmailMessage header#2924

Merged
srittau merged 3 commits intopython:masterfrom
utkarsh2102:email_header
Oct 10, 2019
Merged

message.pyi: Now takes Address as EmailMessage header#2924
srittau merged 3 commits intopython:masterfrom
utkarsh2102:email_header

Conversation

@utkarsh2102
Copy link
Contributor

Fixes #2863

Copy link
Collaborator

@srittau srittau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be better to distinguish between header types for arguments (an Union) and for return types (Any).

@utkarsh2102 utkarsh2102 requested a review from srittau October 9, 2019 20:56
@srittau srittau merged commit 1a932ce into python:master Oct 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Email example from python docs doesn't validate: Address as EmailMessage header

3 participants