Merged
Conversation
Contributor
|
Would it make sense to merge the Python 2 and Python 3 version of |
JelleZijlstra
requested changes
Jun 13, 2017
| skipinitialspace = ... # type: bool | ||
| lineterminator = ... # type: str | ||
| quoting = ... # type: int | ||
| def __init__(self) -> None: ... |
Member
There was a problem hiding this comment.
At least in master, there's also strict: int.
stdlib/3/csv.pyi
Outdated
| QUOTE_MINIMAL = ... # type: int | ||
| QUOTE_NONE = ... # type: int | ||
| QUOTE_NONNUMERIC = ... # type: int | ||
| from _csv import _reader, _writer, reader, writer, register_dialect, unregister_dialect, get_dialect, list_dialects, field_size_limit, QUOTE_ALL, QUOTE_MINIMAL, QUOTE_NONE, QUOTE_NONNUMERIC |
Member
There was a problem hiding this comment.
To re-export these here, you need to write from _csv import reader as reader and similar.
stdlib/3/csv.pyi
Outdated
| dialect = ... # type: Any | ||
| line_num = ... # type: int | ||
| fieldnames = ... # type: Sequence[str] | ||
| def __init__(self, f: Iterator[str], fieldnames: Sequence[str] = ..., restkey: Optional[str] =..., restval: Optional[str] = ..., dialect: Any =..., *args: Any, **kwds: Any) -> None: ... |
Member
There was a problem hiding this comment.
space after each = (also on line 57 below)
Contributor
Author
|
Fixed errors pointed by @JelleZijlstra, and merged the Python 2 version and the Python 3 version. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update stub for csv. Fixes #1277 and #1381.
There are some imprecise type annotations, because I do not now how.