Use TypeIs for various stdlib functions#11823
Merged
JelleZijlstra merged 3 commits intopython:mainfrom Apr 26, 2024
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Member
Author
|
Primer analysis:
|
Collaborator
|
Looks good to me. The mypy bug (if it turns out to be one) seems obscure enough that the improvements this brings are worth it. |
Contributor
|
Diff from mypy_primer, showing the effect of this PR on open source code: vision (https://github.com/pytorch/vision)
+ torchvision/models/_api.py:128: error: Unused "type: ignore" comment [unused-ignore]
antidote (https://github.com/Finistere/antidote)
+ src/antidote/lib/lazy_ext/_lazy.py:171: error: Non-overlapping identity check (left operand type: "Literal[FunctionKind.VALUE]", right operand type: "Literal[FunctionKind.METHOD]") [comparison-overlap]
+ src/antidote/lib/lazy_ext/_lazy.py:174: error: Unused "type: ignore" comment [unused-ignore]
+ src/antidote/lib/lazy_ext/_lazy.py:178: error: Non-overlapping identity check (left operand type: "Literal[FunctionKind.VALUE]", right operand type: "Literal[FunctionKind.PROPERTY]") [comparison-overlap]
+ src/antidote/lib/lazy_ext/_lazy.py:181: error: Unused "type: ignore" comment [unused-ignore]
+ src/antidote/lib/lazy_ext/_lazy.py:185: error: Non-overlapping identity check (left operand type: "Literal[FunctionKind.VALUE]", right operand type: "Literal[FunctionKind.FUNCTION]") [comparison-overlap]
+ tests/lib/interface/test_function.py:44: error: Unused "type: ignore" comment [unused-ignore]
+ tests/lib/interface/test_function.py:45: error: Unused "type: ignore" comment [unused-ignore]
+ tests/lib/interface/test_function.py:78: error: Unused "type: ignore" comment [unused-ignore]
+ tests/lib/interface/test_function.py:79: error: Unused "type: ignore" comment [unused-ignore]
+ tests/lib/interface/test_function.py:83: error: Unused "type: ignore" comment [unused-ignore]
+ tests/lib/interface/test_function.py:86: error: Unused "type: ignore" comment [unused-ignore]
+ tests/lib/interface/test_function.py:89: error: Unused "type: ignore" comment [unused-ignore]
+ tests/lib/interface/test_function.py:145: error: Unused "type: ignore" comment [unused-ignore]
+ tests/lib/interface/test_function.py:154: error: Unused "type: ignore" comment [unused-ignore]
+ tests/lib/interface/test_function.py:174: error: Unused "type: ignore" comment [unused-ignore]
+ tests/lib/interface/test_function.py:188: error: Unused "type: ignore" comment [unused-ignore]
+ tests/lib/interface/test_function.py:191: error: Unused "type: ignore" comment [unused-ignore]
+ tests/lib/interface/test_function.py:194: error: Unused "type: ignore" comment [unused-ignore]
pytest (https://github.com/pytest-dev/pytest)
+ testing/test_monkeypatch.py:418: error: Statement is unreachable [unreachable]
spark (https://github.com/apache/spark)
+ python/pyspark/sql/worker/write_into_data_source.py:157: error: Unused "type: ignore" comment [unused-ignore]
+ python/pyspark/sql/worker/write_into_data_source.py:164: error: Unused "type: ignore" comment [unused-ignore]
+ python/pyspark/sql/worker/create_data_source.py:131: error: Unused "type: ignore" comment [unused-ignore]
+ python/pyspark/sql/worker/create_data_source.py:156: error: Unused "type: ignore" comment [unused-ignore]
+ python/pyspark/sql/worker/create_data_source.py:166: error: Unused "type: ignore" comment [unused-ignore]
+ python/pyspark/sql/worker/create_data_source.py:168: error: Unused "type: ignore" comment [unused-ignore]
jinja (https://github.com/pallets/jinja)
+ src/jinja2/async_utils.py:67: error: Redundant cast to "V" [redundant-cast]
discord.py (https://github.com/Rapptz/discord.py)
+ discord/utils.py:695: error: Unused "type: ignore" comment [unused-ignore]
+ discord/utils.py:701: error: Incompatible default for argument "check" (default has type "Callable[[object], TypeIs[Awaitable[Any]]]", argument has type "Callable[[T | Awaitable[T]], TypeGuard[Awaitable[T]]]") [assignment]
|
Member
Author
|
I tracked it down to a preexisting mypy bug: python/mypy#8869. Given that it's a bug that is not directly related to TypeIs, I agree this is worth merging. |
Collaborator
|
Hooray for the new semantics! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #11453. This should start working when mypy 1.10 is released, which should be very soon.