Skip to content

Use Any for field type in make_dataclass #11657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
AlexWaygood merged 4 commits into from
Mar 25, 2024
Merged

Use Any for field type in make_dataclass #11657

AlexWaygood merged 4 commits into from
Mar 25, 2024

Conversation

@alexei
Copy link
Contributor

@alexei alexei commented Mar 25, 2024

Fixes #11653

@alexei alexei mentioned this pull request Mar 25, 2024
Closed
@github-actions

This comment has been minimized.

Sign in to view
AlexWaygood
AlexWaygood approved these changes Mar 25, 2024
View reviewed changes
Copy link
Member

@AlexWaygood AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@hauntsaninja
Copy link
Collaborator

hauntsaninja commented Mar 25, 2024

Can this be object instead?

@JelleZijlstra
Copy link
Member

JelleZijlstra commented Mar 25, 2024

I think Any is more appropriate because we don't really want to accept all objects. For example, ideally we'd reject make_dataclass("T", [("x", 1)]).

@AlexWaygood
Copy link
Member

AlexWaygood commented Mar 25, 2024

Yeah, I agree with Jelle. It can't actually be any object, so object isn't really accurate. The type just can't be expressed without a TypeForm-esque thing.

@github-actions

This comment has been minimized.

Sign in to view
JelleZijlstra
JelleZijlstra reviewed Mar 25, 2024
View reviewed changes
@github-actions
Copy link
Contributor

github-actions bot commented Mar 25, 2024

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

@AlexWaygood AlexWaygood changed the title fix: use Any for field type in make_dataclass Use Any for field type in make_dataclass Mar 25, 2024
@AlexWaygood AlexWaygood merged commit 4df0725 into python:main Mar 25, 2024
@AlexWaygood
Copy link
Member

AlexWaygood commented Mar 25, 2024

Thanks @alexei!

@alexei alexei deleted the fix-11653-make_dataclass_type_hints branch March 26, 2024 11:20
@alexei
Copy link
Contributor Author

alexei commented Mar 26, 2024

Thanks guys!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AlexWaygood AlexWaygood AlexWaygood approved these changes

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

dataclasses.make_dataclass should accept Any, not type

4 participants

@alexei @hauntsaninja @JelleZijlstra @AlexWaygood