tensorflow: Add tensorflow.keras.models.Model#11334
Merged
JelleZijlstra merged 32 commits intopython:mainfrom Mar 13, 2024
Merged
tensorflow: Add tensorflow.keras.models.Model#11334JelleZijlstra merged 32 commits intopython:mainfrom
tensorflow: Add tensorflow.keras.models.Model#11334JelleZijlstra merged 32 commits intopython:mainfrom
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
ecc3cfb to
a151415
Compare
ecc3cfb to
a151415
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
d16ecaf to
b11dd65
Compare
This comment has been minimized.
This comment has been minimized.
JelleZijlstra
approved these changes
Mar 12, 2024
Member
JelleZijlstra
left a comment
There was a problem hiding this comment.
Skimmed through, seems fine.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Member
|
Another round of merge conflicts, could you take a look? I'm planning to merge #11333 once CI is green, which might trigger some more merge conflicts. |
cb3efa7 to
8b672df
Compare
8b672df to
104164a
Compare
Contributor
|
Diff from mypy_primer, showing the effect of this PR on open source code: jax (https://github.com/google/jax)
+ jax/experimental/jax2tf/tests/tf_test_util.py:114: error: Incompatible return value type (got "tuple[Any, Module]", expected "tuple[Callable[..., Any], Checkpoint]") [return-value]
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR will add the TensorFlow Model class once the other TensorFlow PRs have been fixed and merged.