posixpath.commonpath supports Iterable parameter#11310
Merged
Conversation
2 tasks
Contributor
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
commonpath support Iterableposixpath.commonpath supportsIterable parameter
posixpath.commonpath supportsIterable parameterposixpath.commonpath supports Iterable parameter
srittau
approved these changes
Jan 29, 2024
Collaborator
srittau
left a comment
There was a problem hiding this comment.
One slight issue in the implementation: It's doing if not paths to check for an empty sequence, which won't work with iterables. I'll send a PR to CPython as the fix is trivial.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pathsis immediately passed to amap, an iterable should work. Fixes https://github.com/pypa/setuptools/pull/3979/files#diff-6c888d2f35e4149ad56292334032e9a216d1ab2b32a4df3c791d864c42dfad04R603