Skip to content

itsdangerous.TimedJSONWebSignatureSerializer.dumps incorrect return type on python 3 #3081

@redshiftzero

Description

@redshiftzero

On Python 3, the return value for itsdangerous.TimedJSONWebSignatureSerializer.dumps is bytes not str so I think the return type should be Union[bytes, str]

Python 3.7

>>> from itsdangerous import TimedJSONWebSignatureSerializer
>>> s = TimedJSONWebSignatureSerializer('test')
>>> test_obj = s.dumps({'foo': 'bar'})
>>> type(test_obj)
<class 'bytes'>

Python 2.7

>>> from itsdangerous import TimedJSONWebSignatureSerializer
>>> s = TimedJSONWebSignatureSerializer('test')
>>> test_obj = s.dumps({'foo': 'bar'})
>>> type(test_obj)
<type 'str'>

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions