Add benchmark reading instance variables defined by __slots__ #86
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vstinner
reviewed
Jan 15, 2021
Member
vstinner
left a comment
There was a problem hiding this comment.
I'm not really excited by micro-benchmarks like "read an atribute". Such micro-benchmark is usually unstable and so not very useful to track Python performance over time. We tried to put "macro" benchmarks on pyperformance, more "realistic" "real world" work loads (please don't look into details ;-)).
Member
Author
|
No problem, this was suggested to me. I'll withdraw it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Copied some parts from bm_float.py)