Merged
Conversation
JelleZijlstra
approved these changes
Apr 23, 2024
Member
JelleZijlstra
left a comment
There was a problem hiding this comment.
I think this is fine. I'd even be OK with dropping 3.9 entirely here; it's not all that important for the PEP build scripts to have wide Python version support.
5 tasks
Member
Author
|
Yeah, I'd be fine dropping 3.9 too, but we decided a while back not to require the cutting edge so PEP authors could use a wider range of versions. Although 3.9/3.10 are hardly cutting edge by now :) Anyway, this is an easy enough fix to keep them all for now. |
5 tasks
2 tasks
1 task
2 tasks
maremango
approved these changes
Dec 28, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3760 (comment).
Re: actions/setup-python#696 (comment).
There's a couple of similar ways to do this, for this workflow the difference is mostly cosmetic.
Any preferences?
This PR: keep 3.9 in the matrix (it adds Windows, Ubuntu and
macos-latest), then remove 3.9/macos-latestand include 3.9/macos-13:diff
It runs 3.9/
macos-13last, the othe 3.9s stay at the top:Benefit: only one moved to the end, still get to queue up the slowish 3.9/Windows sooner to give it a headstart.
Or remove 3.9 from the matrix, then add 3.9 and Windows, Ubuntu and
macos-latest:diff
It runs all 3.9 jobs at the end:
Benefit: all 3.9 jobs kept together.
📚 Documentation preview 📚: https://pep-previews--3763.org.readthedocs.build/