Skip to content

PEP 686: Update based on discussion#2446

Merged
methane merged 6 commits into
python:mainfrom
methane:pep-686
Mar 22, 2022
Merged

PEP 686: Update based on discussion#2446
methane merged 6 commits into
python:mainfrom
methane:pep-686

Conversation

@methane

@methane methane commented Mar 19, 2022

Copy link
Copy Markdown
Member

No description provided.

@methane methane requested a review from zooba March 19, 2022 02:51
@CAM-Gerlach CAM-Gerlach changed the title PEP 686: Update based on discussion. PEP 686: Update based on discussion Mar 19, 2022
@methane methane requested review from CAM-Gerlach and ncoghlan March 20, 2022 03:05
Comment thread pep-0686.rst
* Most websites and text data on the internet uses UTF-8.
* And many other popular programming languages including node.js, Go, Rust,
Ruby, and Java uses UTF-8 by default.
and Java uses UTF-8 by default.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed Ruby here because Ruby still uses locale encoding on Unix.

@CAM-Gerlach CAM-Gerlach left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from a technical/PEP 12 perspective, thanks. If you'd like me to help copyedit/proofread the text for grammar, etc, I'm happy to do so (it would probably be best to do so as a separate PR for your review once this is merged); just let me know.

@ncoghlan

Copy link
Copy Markdown
Contributor

This update cleanly addresses the concern I raised on Discourse.

@methane methane merged commit 04eb449 into python:main Mar 22, 2022
@methane

methane commented Mar 22, 2022

Copy link
Copy Markdown
Member Author

Thank you for review. I merge this for now to continue more discussions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants