PEP 658: Static Distribution Metadata in the Simple Repository API#1955
PEP 658: Static Distribution Metadata in the Simple Repository API#1955JelleZijlstra merged 3 commits intopython:masterfrom
Conversation
|
You can take PEP 658; #1944 will need to be renumbered anyway. |
|
This looks broadly good to me. I spotted a couple of typos, I'll do a proper review when I have more time. |
6b53596 to
82f7251
Compare
|
Thanks, I’ve assigned the number and added the newly-created Discourse link to the document. I admit I didn’t re-read the document myself after writing it 😓 |
JelleZijlstra
left a comment
There was a problem hiding this comment.
Couple of small suggestions, reading the rest now
pep-0658.rst
Outdated
| PEP: 658 | ||
| Title: Static Distribution Metadata in the Simple Repository API | ||
| Author: Tzu-ping Chung <uranusjr@gmail.com> | ||
| Sponsor: |
There was a problem hiding this comment.
I’m not sure whether Paul or Donald is better to put in which fields TBH
There was a problem hiding this comment.
As this is package index stuff, @dstufft is PEP-delegate by default. He can get someone else to handle it if he prefers, and I'd be willing to do it if he wants to pass the job on.
I'd rather not be sponsor, TBH. With the new CODEOWNERS workflow, it looks like that means I'd now be responsible for merging any PRs to the PEP and I don't really have the time to handle that right now...
There was a problem hiding this comment.
With the new CODEOWNERS workflow, it looks like that means I'd now be responsible for merging any PRs to the PEP
I'm happy to remain as chief button-pusher to merge uncontroversial PRs :). I think the main point of the CODEOWNERS change is to make it easier for sponsors to stay up to date on changes to their PEPs, but they don't necessarily have to take care of all changes.
There was a problem hiding this comment.
Donald is gonna be the delegate IIUC, based on the SC's standing delegation for Package Index stuff.
Sponsor is... well, whoever ends up sponsoring this.
JelleZijlstra
left a comment
There was a problem hiding this comment.
The text looks good now, thanks! As @pradyunsg mentioned you'll have to add to the CODEOWNERS file and specify a sponsor.
Based on feedback, the metadata file of a distribution is now served at a pre-determined location (with a ".metadata" suffix), instead of allowing the repository to specify one. The data-dist-info-metadata attribute's value is re-purposed to store the metadata file's hash for validation, based on another suggestion.
|
The sponsor has been set to @brettcannon (ref) and the PEP delegate @dstufft (as the standing delegate). I also made some changes to the proposal according to early feedback. |
Spawned from pypi/warehouse#8254. Missing fields to be filled later after a number is assigned.