New semantic analyzer: fix false positives from TypedDict in stub#7063
Merged
New semantic analyzer: fix false positives from TypedDict in stub#7063
Conversation
ilevkivskyi
approved these changes
Jun 25, 2019
mypy/newsemanal/semanal_classprop.py
Outdated
| if typ.declared_metaclass and typ.declared_metaclass.type.fullname() == 'abc.ABCMeta': | ||
| return | ||
| if typ.is_protocol: | ||
| if typ.is_protocol or typ.typeddict_type: |
Member
There was a problem hiding this comment.
I am curious why this is not needed in the old analyzer. Is it an old analyzer bug?
Collaborator
Author
There was a problem hiding this comment.
I think that the old semantic analyzer just doesn't run this code at all for TypedDicts.
Collaborator
Author
There was a problem hiding this comment.
I updated the code to be closer to the logic in the old semantic analyzer.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7028.