Fix mypy tests for contextlib change in typeshed PR 3083#6958
Merged
ilevkivskyi merged 1 commit intopython:masterfrom Jul 2, 2019
Merged
Fix mypy tests for contextlib change in typeshed PR 3083#6958ilevkivskyi merged 1 commit intopython:masterfrom
ilevkivskyi merged 1 commit intopython:masterfrom
Conversation
ilevkivskyi
reviewed
Jun 13, 2019
427f28c to
d360f91
Compare
d360f91 to
a19dcdb
Compare
Contributor
|
@JelleZijlstra @ilevkivskyi I'd like to get the corresponding typeshed fix (python/typeshed#3083) merged. What's the status of this PR? |
Member
|
Merging this will require a complicated dance of merging the typeshed PR + syncing the typeshed submodule in mypy + merging this PR. I can do it at some point but don't have time right now. |
Member
|
I can do the typeshed dance now. |
Merged
ilevkivskyi
approved these changes
Jul 2, 2019
Member
ilevkivskyi
left a comment
There was a problem hiding this comment.
I prepared the typeshed sync. I will merge this right after it lands.
Member
|
I have restarted all builds, should be green now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
python/typeshed#3083 fixed an issue in the
contextlibstub file, which broke an existing mypy test that was written based off the incorrect stub file.NOTE:
This commit will have to synced with that change to fix the tests + add new
decoratortests.