Fix multiple inheritance check for generic classes#6720
Merged
ilevkivskyi merged 6 commits intopython:masterfrom Apr 25, 2019
Merged
Fix multiple inheritance check for generic classes#6720ilevkivskyi merged 6 commits intopython:masterfrom
ilevkivskyi merged 6 commits intopython:masterfrom
Conversation
ilevkivskyi
commented
Apr 25, 2019
| first = base1[name] | ||
| second = base2[name] | ||
| first = base1.names[name] | ||
| second = base2.names[name] |
Member
Author
There was a problem hiding this comment.
This change is not needed, but it makes the intent of this method more evident.
msullivan
approved these changes
Apr 25, 2019
Collaborator
msullivan
left a comment
There was a problem hiding this comment.
This looks great. Thanks for adding documentation too!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5973
The fix is straightforward, I just copy a bit of logic (bind self and map type) from normal override check
to the multiple inheritance one (I also factored it out in a small method to avoid duplication).
Using this opportunity I also added/expanded some docstrings.