Skip to content

[mypyc] Loading type from imported modules. #18158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
hauntsaninja merged 1 commit into from
Nov 16, 2024
Merged

[mypyc] Loading type from imported modules. #18158

hauntsaninja merged 1 commit into from
Nov 16, 2024

Conversation

@advait-dixit
Copy link
Contributor

@advait-dixit advait-dixit commented Nov 16, 2024

Fixes #1075

Previously, this compiled but failed to run:

import collections
from typing_extensions import TypedDict
class C(TypedDict):
    x: collections.deque

Although type of x was being inferred correctly, it was not looking for collections.deque in imported modules.

hauntsaninja
hauntsaninja approved these changes Nov 16, 2024
View reviewed changes
Copy link
Collaborator

@hauntsaninja hauntsaninja left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not too familiar with mypyc, but this looks good, thank you!

@hauntsaninja hauntsaninja merged commit 8ef2197 into python:master Nov 16, 2024
@advait-dixit advait-dixit deleted the mypyc-fix-ann-non-ext-cls branch November 17, 2024 01:09
@advait-dixit advait-dixit mentioned this pull request Nov 28, 2024
Closed
@sterliakov sterliakov mentioned this pull request Feb 13, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hauntsaninja hauntsaninja hauntsaninja approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

TypedDict from compiled module causes KeyError for certain annotations

2 participants

@advait-dixit @hauntsaninja