Skip to content

gh-98284: better error message for undefined abstractmethod #97971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JelleZijlstra merged 5 commits into from
Nov 5, 2022
Merged

gh-98284: better error message for undefined abstractmethod #97971

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c268395
[abc] better error message for undefined abstractmethod
kaushikcfd Oct 6, 2022
3603740
adds a NEWS entry
kaushikcfd Oct 9, 2022
4073b1f
corrects the NEWS entry
kaushikcfd Oct 15, 2022
6a762e4
Merge remote-tracking branch 'upstream/main' into abc_better_err_msg
kaushikcfd Oct 15, 2022
6ae052e
Avoid leaks by calling Py_DECREF in some code paths
kaushikcfd Nov 5, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Avoid leaks by calling Py_DECREF in some code paths
  • Loading branch information
@kaushikcfd
kaushikcfd committed Nov 5, 2022
commit 6ae052ef771eb9e72f7cbb90b58a2bb1d10ae3f5
9 changes: 7 additions & 2 deletions Objects/typeobject.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4881,10 +4881,15 @@ object_new(PyTypeObject *type, PyObject *args, PyObject *kwds)
joined = PyUnicode_Join(comma_w_quotes_sep, sorted_methods);
method_count = PyObject_Length(sorted_methods);
Py_DECREF(sorted_methods);
if (joined == NULL)
if (joined == NULL) {
Py_DECREF(comma_w_quotes_sep);
return NULL;
if (method_count == -1)
}
if (method_count == -1) {
Py_DECREF(comma_w_quotes_sep);
Py_DECREF(joined);
return NULL;
}

PyErr_Format(PyExc_TypeError,
"Can't instantiate abstract class %s "
Expand Down