[Enum] Remove unused code from test_enum.py#96986
Merged
ethanfurman merged 1 commit intopython:mainfrom Dec 7, 2022
Merged
Conversation
ethanfurman
reviewed
Sep 21, 2022
Member
ethanfurman
left a comment
There was a problem hiding this comment.
I need to look more closely at the two _dir entries and make sure they shouldn't be used.
Member
Author
|
They might be. I was in doubt about them. But these lines look like they do something very similar: https://github.com/python/cpython/pull/96986/files#diff-8467f9fbbff81abf26d87a8dbbf0e0c866157971948010e48cc73539251a9e4cL4519-L4525 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While reading #96475 I found that there are some unused definitions on
test_enum.pythat should be removed.I am not going to open an issue about that, because it is a test-only minor detail 👍