Skip to content

[3.6] bpo-34819: Use a monotonic clock to compute timeouts in concurrent.futures (GH-9599)#9600

Merged
miss-islington merged 1 commit into
python:3.6from
miss-islington:backport-a94ee12-3.6
Sep 27, 2018
Merged

[3.6] bpo-34819: Use a monotonic clock to compute timeouts in concurrent.futures (GH-9599)#9600
miss-islington merged 1 commit into
python:3.6from
miss-islington:backport-a94ee12-3.6

Conversation

@miss-islington

@miss-islington miss-islington commented Sep 27, 2018

Copy link
Copy Markdown
Contributor

Use a monotonic clock to compute timeouts in :meth:Executor.map and :func:as_completed, in order to prevent timeouts from deviating when the system clock is adjusted.

This may not be sufficient on all systems. On POSIX for example, the actual waiting (e.g. in sem_timedwait) is specified to rely on the CLOCK_REALTIME clock.
(cherry picked from commit a94ee12)

Co-authored-by: orlnub123 orlnub123@gmail.com

https://bugs.python.org/issue34819

…tures (pythonGH-9599)

Use a monotonic clock to compute timeouts in :meth:`Executor.map` and :func:`as_completed`, in order to prevent timeouts from deviating when the system clock is adjusted.

This may not be sufficient on all systems. On POSIX for example, the actual waiting (e.g. in ``sem_timedwait``) is specified to rely on the CLOCK_REALTIME clock.
(cherry picked from commit a94ee12)

Co-authored-by: orlnub123 <orlnub123@gmail.com>

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good bot.

@miss-islington

Copy link
Copy Markdown
Contributor Author

@orlnub123 and @pitrou: Status check is done, and it's a success ✅ .

@miss-islington miss-islington merged commit 3a4aa6a into python:3.6 Sep 27, 2018
@miss-islington miss-islington deleted the backport-a94ee12-3.6 branch September 27, 2018 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants