bpo-34814: Fix Modules/makesetup for shared libraries #9593
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix Modules/makesetup script for shared libraries. When Modules/Setup is modified to compile C extensions as shared libraries using Makefile, make sure that the generated shared library is linked to libpython3.X. Add also a dependency on the Makefile target to libpython, to make sure that the parallel compilation works as expected.
Member
|
I think the opposite should be done (never link with |
Member
Author
|
I closed https://bugs.python.org/issue34814 as "not a bug", so I close this PR as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix Modules/makesetup script for shared libraries. When Modules/Setup
is modified to compile C extensions as shared libraries using
Makefile, make sure that the generated shared library is linked to
libpython3.X.
Add also a dependency on the Makefile target to libpython, to make
sure that the parallel compilation works as expected.
https://bugs.python.org/issue34814