Skip to content

Conversation

@magmax
Copy link
Contributor

@magmax magmax commented Sep 18, 2018

Method gather require to close parenthesis, but it is being closed twice.

https://bugs.python.org/issue33649

miss-islington and others added 30 commits July 9, 2018 12:37
Initial patch by Joshua Jay Herman.
(cherry picked from commit 9863de0)

Co-authored-by: Berker Peksag <berker.peksag@gmail.com>
Follow up from https://github.com/python/peps/pull/712GH-issuecomment-403591108:

"people using the repo without using GitHub still ought to be reminded of the COC" - GvR
(cherry picked from commit 3ed9192)

Co-authored-by: Mariatta <Mariatta@users.noreply.github.com>
(cherry picked from commit d6d4432)

Co-authored-by: Benjamin Peterson <benjamin@python.org>
(cherry picked from commit 7762e4d)

Co-authored-by: Benjamin Peterson <benjamin@python.org>
…H-8184)

(cherry picked from commit 445f1b3)

Co-authored-by: Dong-hee Na <donghee.na92@gmail.com>
Contributed by Bradley Laney.
(cherry picked from commit 6b490b5)

Co-authored-by: Bradley Laney <bradley.laney@gmail.com>
Many users won't realise the implications the OpenSSL 1.0.2
minimum version requirement has when it comes to Ubuntu
14.04 and Debian 8, so expand on that in the platform support
section.

Also explicitly note the non-ASCII-based locale requirement for
full Unicode text handling support on non-Windows systems.
(cherry picked from commit 5fe7c98)

Co-authored-by: Nick Coghlan <ncoghlan@gmail.com>
The ValueError message ends with a period.
(cherry picked from commit 9cffdbf)

Co-authored-by: Lysandros Nikolaou <lisandrosnik@gmail.com>
…rather than an integer. (pythonGH-8038) (pythonGH-8237)

Change example function to append rather than add lists.
(cherry picked from commit da5e947)

Co-authored-by: Tom Faulkner <tomfaulkner@gmail.com>
(cherry picked from commit 33aefad)

Co-authored-by: Andrés Delfino <adelfino@gmail.com>
(cherry picked from commit 5e5bbbe)

Co-authored-by: Stig Johan Berggren <stigjb@gmail.com>
) (pythonGH-8247)

Change test_logging.SMTPHandlerTest timeout from 8 seconds to 1
minute. The test failed randomly on the slow x86 Gentoo Refleaks 3.7
buildbot.
(cherry picked from commit 31b50b8)

Co-authored-by: Victor Stinner <vstinner@redhat.com>
This code does not appear to be used anywhere in the python code base.
The use was removed in eb81795.
(cherry picked from commit b91a3a0)

Co-authored-by: Eitan Adler <grimreaper@users.noreply.github.com>
(cherry picked from commit 504373c)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
(cherry picked from commit 993030a)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
Increase the timeout from 1 min to 5 min.

Replace also time.time() with time.monotonic() for timeouts.
(cherry picked from commit 3ad8dec)

Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>
The test failed on AMD64 Debian root 3.x buildbot because the busy
loop of 100 ms only increased time.thread_time() by 19.9 ms which is
smaller than 20 ms. Modify the test to tolerate a delta of at least
15 ms instead of 20 ms.
(cherry picked from commit d6345de)

Co-authored-by: Victor Stinner <vstinner@redhat.com>
(cherry picked from commit 379e9d6)

Co-authored-by: Andrés Delfino <adelfino@gmail.com>
…) (python#8275)

* Add test capturing failure.
* Honor newlines as present in the original file.
(cherry picked from commit cafaf04)

Co-authored-by: Jason R. Coombs <jaraco@jaraco.com>
…nGH-8274)

`_PyUnicode_TransformDecimalAndSpaceToASCII()` missed trailing NUL char.
It caused buffer overflow in `_Py_string_to_number_with_underscores()`.

This bug is introduced in 9b6c60c.
(cherry picked from commit 16dfca4)

Co-authored-by: INADA Naoki <methane@users.noreply.github.com>
(cherry picked from commit 15c7b2a)

Co-authored-by: Benjamin Peterson <benjamin@python.org>
Check that the size of the varnames tuple is enough at least for all arguments.
(cherry picked from commit bd47384)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
…pythonGH-8294)

Replace deprecated inspect.getfullargspec() with inspect.signature().
(cherry picked from commit 35c0809)

Co-authored-by: Nicolas Noé <nicolas@niconoe.org>
…) (pythonGH-8296)

It was added in test_functools at 445f1b3.
(cherry picked from commit 9e9b2c3)

Co-authored-by: Zackery Spytz <zspytz@gmail.com>
…GH-8297)

(cherry picked from commit c9265c1)

Co-authored-by: Jon Ribbens <jribbens@gmail.com>
(cherry picked from commit 56d8f57)

Co-authored-by: INADA Naoki <methane@users.noreply.github.com>
… an exception set (pythonGH-8282)

(cherry picked from commit 28f0736)

Co-authored-by: Zackery Spytz <zspytz@gmail.com>
(cherry picked from commit feabae9)

Co-authored-by: Raymond Hettinger <rhettinger@users.noreply.github.com>
* bpo-34130: Fix test_signal.test_socket() (pythonGH-8326)

test_signal.test_socket(): On Windows, sometimes even if the C signal handler
succeed to write the signal number into the write end of the socketpair, the
test fails with a BlockingIOError on the non-blocking read.recv(1) because the
read end of the socketpair didn't receive the byte yet.

Fix the race condition on Windows by setting the read end as blocking.

(cherry picked from commit 99bb6df)

* bpo-34130: Fix test_signal.test_warn_on_full_buffer() (pythonGH-8327)

On Windows, sometimes test_signal.test_warn_on_full_buffer() fails to
fill the socketpair buffer. In that case, the C signal handler
succeed to write into the socket, it doesn't log the expected send
error, and so the test fail.

On Windows, the test now uses a timeout of 50 ms to fill the
socketpair buffer to fix this race condition.

Other changes:

* Begin with large chunk size to fill the buffer to speed up the
  test.
* Add error messages to assertion errors to more easily identify
  which assertion failed.
* Don't set the read end of the socketpair as non-blocking.

(cherry picked from commit 686b4b5)
miss-islington and others added 15 commits September 15, 2018 00:30
(cherry picked from commit 2087023)

Co-authored-by: Tony Flury <anthony.flury@btinternet.com>
…-8950)

(cherry picked from commit 10a428b)

Co-authored-by: Monson Shao <holymonson@gmail.com>
…ythonGH-9258)

(cherry picked from commit 7843cae)

Co-authored-by: Vladimir Matveev <v2matveev@outlook.com>
…honGH-9113)

(cherry picked from commit e0e5065)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
Include ``openssl/dh.h`` header file to fix implicit function declaration of ``DH_free()``.

Signed-off-by: Alexandru Ardelean <ardeleanalex@gmail.com>
(cherry picked from commit b3a271f)

Co-authored-by: Alexandru Ardelean <ardeleanalex@gmail.com>
…ythonGH-8683)

(cherry picked from commit 9bdb7be)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
…) (pythonGH-8784)

(cherry picked from commit 5e99b56)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
)

(cherry picked from commit c6fd1c1)

Co-authored-by: Steve Dower <steve.dower@microsoft.com>
The test tries to fill the receiver's socket buffer and expects an
error. But the RDS protocol doesn't require that. Moreover, the Linux
implementation of RDS expects that the producer of the messages
reduces its rate, it's not the role of the receiver to trigger an
error.

The test fails on Fedora 28 by design, so remove it.
(cherry picked from commit 7484bdf)

Co-authored-by: Victor Stinner <vstinner@redhat.com>
)

(cherry picked from commit 6750922)

Co-authored-by: Steve Dower <steve.dower@microsoft.com>
…H-9370)

(cherry picked from commit c62ab28)

Co-authored-by: Yury Selivanov <yury@magic.io>
… by default (pythonGH-9379)

* bpo-34589: Make _PyCoreConfig.coerce_c_locale private (pythonGH-9371)

_PyCoreConfig:

* Rename coerce_c_locale to _coerce_c_locale
* Rename coerce_c_locale_warn to _coerce_c_locale_warn

These fields are now private (name prefixed by "_").

(cherry picked from commit 188ebfa)

* bpo-34589: C locale coercion off by default (pythonGH-9073)

Py_Initialize() and Py_Main() cannot enable the C locale coercion
(PEP 538) anymore: it is always disabled. It can now only be enabled
by the Python program ("python3).

test_embed: get_filesystem_encoding() doesn't have to set PYTHONUTF8
nor PYTHONCOERCECLOCALE, these variables are already set in the
parent.

(cherry picked from commit 7a0791b)

* bpo-34589: Add -X coerce_c_locale command line option (pythonGH-9378)

Add a new -X coerce_c_locale command line option to control C locale
coercion (PEP 538).

(cherry picked from commit dbdee00)
…GH-9380)

(cherry picked from commit ac94e38)

Co-authored-by: Yury Selivanov <yury@magic.io>
Method `gather` require to close parenthesis, but it is being closed twice.
@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately our records indicate you have not signed the CLA. For legal reasons we need you to sign this before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for your contribution, we look forward to reviewing it!

@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels Sep 18, 2018
@1st1 1st1 changed the title Fix syntax error on factorial example for asyncio bpo-33649: Fix syntax error on factorial example for asyncio Sep 18, 2018
@1st1
Copy link
Member

1st1 commented Sep 18, 2018

Oh, could you please retarget this PR to the master branch? Thanks!

@magmax
Copy link
Contributor Author

magmax commented Sep 18, 2018

Sure!

@magmax magmax changed the base branch from 3.7 to master September 18, 2018 05:31
@1st1
Copy link
Member

1st1 commented Sep 18, 2018

Oh... I think it would be easier to just open one new PR to fix this in the master branch (right now there seems to be a weird conflict or something..)

A PR to fix this in 3.7 will be created automatically by our bots.

@1st1 1st1 closed this Sep 18, 2018
@magmax
Copy link
Contributor Author

magmax commented Sep 18, 2018

Done: #9387

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting review docs Documentation in the Doc dir skip news

Projects

None yet

Development

Successfully merging this pull request may close these issues.