Skip to content

bpo-33649: A copy-editing pass on asyncio documentation #9376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
1st1 merged 4 commits into from
Sep 17, 2018
Merged

bpo-33649: A copy-editing pass on asyncio documentation #9376

1st1 merged 4 commits into from
Sep 17, 2018

Conversation

@elprans
Copy link
Contributor

@elprans elprans commented Sep 17, 2018 •
edited by bedevere-bot
Loading

@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels Sep 17, 2018
@1st1 1st1 self-assigned this Sep 17, 2018
@1st1 1st1 added the skip news label Sep 17, 2018
1st1
1st1 reviewed Sep 17, 2018
View reviewed changes
Doc/library/asyncio-task.rst Outdated
return_when=ALL_COMPLETED)

Wait for a set of Futures to complete.
Wait for a set of couroutines, Tasks, or Futures to complete.
Copy link
Member

@1st1 1st1 Sep 17, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couroutines -> coroutines

1st1
1st1 reviewed Sep 17, 2018
View reviewed changes
Doc/library/asyncio-protocol.rst Outdated

The defaults are implementation-specific. If only the
high-water limit is given, the low-water limit defaults to an
high watemark is given, the low watermark defaults to an
Copy link
Member

@1st1 1st1 Sep 17, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

watemark -> watermark

1st1
1st1 reviewed Sep 17, 2018
View reviewed changes
Doc/library/asyncio-eventloop.rst Outdated
to use on **Windows** does not support subprocesses.
See :ref:`Subprocess Support on Windows <asyncio-windows-subprocess>`
for details.
The default asyncion event loop on **Windows** does not support
Copy link
Member

@1st1 1st1 Sep 17, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

asyncion -> asyncio

1st1
1st1 reviewed Sep 17, 2018
View reviewed changes
Doc/library/asyncio-platforms.rst Outdated
================

The :mod:`asyncio` module has been designed to be portable,
The :mod:`asyncio` module was designed to be portable,
Copy link
Member

@1st1 1st1 Sep 17, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

was -> is ?

@1st1 1st1 merged commit 1fa2ec4 into python:master Sep 17, 2018
@1st1
Copy link
Member

1st1 commented Sep 17, 2018

Thanks so much, Elvis!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@1st1 1st1 1st1 approved these changes

@asvetlov asvetlov Awaiting requested review from asvetlov

Assignees

@1st1 1st1

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@elprans @1st1 @the-knights-who-say-ni @bedevere-bot