bpo-34660: Replace offensive words #9335

jonsees · 2018-09-15T18:59:46Z

This is a work in progress. Contributor Form has not been reviewed yet, apparently. I'll push more commits in the meantime.

https://bugs.python.org/issue34660

the-knights-who-say-ni · 2018-09-15T18:59:49Z

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for your contribution, we look forward to reviewing it!

I don't want this changed unless backported to 3.7, 3.6. Code changes probably will not be.

terryjreedy

I think the proposed changes are plausible improvements somewhat independent of any offensiveness.

To me, the 'sin' of these words is that they tend to be vague and say more about the writer's opinion than about the ostensible subject. If I were to merge this, I would be tempted to change the title to "Replace vague negative words in code." or "Replacy vague negative value judgments".

I removed the change to idlelib/todo.txt because it is not code and because the decade old file needs much heavier editing, which I would want to backport if and when I do so.

terryjreedy · 2018-09-15T20:20:50Z

Lib/test/test_keyword.py

            "        'also legal',",
            "        'continue',",
-            "        'crazy but legal',",
+            "        'weird but legal',",


Change breaks tests because list must be alphabetically sorted. 'weird by legal' belongs just before 'wigii'.

terryjreedy · 2018-09-15T20:58:27Z

Lib/test/test_decimal.py

            }

-        crazy = {
+        weird = {


There might be an even better name and custom example.

phone = { 'decimal_point': 'x', 'grouping': make_grouping([4, 3, 3, CHAR_MAX]), 'thousands_sep': '-', }

would be useful if one were confronted with phone numbers with extensions stored as Decimals.

terryjreedy · 2018-09-15T21:01:27Z

Lib/test/test_pprint.py

        # Python 2.5, this was in the test_same_as_repr() test.  It's worth
        # keeping around for now because it's one of few tests of pprint
-        # against a crazy mix of types.
+        # against a random mix of types.


From the technical side, I would prefer 'haphazard' or 'arbitrary', as 'random' implies a probability distribution.

terryjreedy · 2018-09-15T21:19:49Z

Lib/test/test_unicode_file_functions.py

            self._apply_failure(os.listdir, name)

    if sys.platform == 'win32':
-        # Windows is lunatic. Issue #13366.


The perjorative dig should just go. Replace with 'Two exceptions are possible.'

bedevere-bot · 2018-09-15T21:46:02Z

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

suic86 · 2018-09-16T19:40:27Z

and you can see evidence of that on the original BPO page

@jonsees are you serious? How can you call that evidence? When you compile 5 random links it doesn't constitute evidence.

There are so many occurrences of problematic words, some of which I haven't even touched.

When @jonsees says that something is problematic then it's problematic? Define what a problematic word is. IMO there's no consensus about.

It is going to end when people stop throwing around insults like "insane" and "mad", and understand that these words make others feel uncomfortable. I won't reply specifically to you anymore, just FYI.

Logic doesn't care about feelings and life isn't about being comfortable. "Insane" and "mad" are plane English words. If these hurt you it's your problem and you don't have the right to censor other people just because of your feelings. I'm happy that I live in a country where this insanity haven't gone this far.

@hawran (I've put it in verbatim tag, as GH removed my <sarcasm> tag.)

<sarcasm>don't bother rock bands. Start with [this](https://www.clearquran.com/#search) or [this](http://www.o-bible.com/cgibin/ob.cgi?version=kjv&search=&keywords=mad)</sarcasm>

hawran · 2018-09-16T19:46:07Z

To whom it may concern:

jonsees
Joined a day ago
(as of 16 Sep 2018)

Is this a common situation?

RaresDima · 2018-09-16T20:35:50Z

This is the same principle that was going on with the master/slave deal a couple days ago.
Ideology and subjective things like what you personally believe are insulting or offensive words is irrelevant in a programming language. The words are not meant to be offensive and it is obvious beyond any reasonable doubt that they are jokes and are in good fun and removing those serves no other reason than to boost someone's ego.

Quite simply the fact that some people feel insecure about some words does not give you the right to censor the world. If you do not like a food, you simply don't go to the restaurant serving it anymore, you don't try to argue with the restaurant that because you don't like it they should not serve it.

The words used are used in good humor and anyone that is not specifically looking for something to be angry about and use as a slingshot to boost their own ago will most likely see it.

terryjreedy · 2018-09-16T21:26:30Z

@jonsees I am a real-life person using my real-life name while I volunteer my time trying to improve Python, which I have done for over 21 years. I have real feelings. I consider your response to my review rude and insulting. Since you do not wish to revise the PR, I close it.

@RaresDima Thank you for writing the rest of what I would like to have said.

willingc · 2018-09-17T01:37:12Z

I've locked this discussion thread for a 7 day cool down period. https://bugs.python.org/msg325507

jonsees added 3 commits September 15, 2018 19:35

Replace "lunatic"

631c500

Replace "lame"

e6c479b

Remove "stupid" and derivatives

1eae722

jonsees requested a review from terryjreedy as a code owner September 15, 2018 18:59

the-knights-who-say-ni added the CLA not signed label Sep 15, 2018

bedevere-bot added the awaiting review label Sep 15, 2018

Replace "crazy"

05ce5d2

jonsees requested review from a team, rhettinger and skrah as code owners September 15, 2018 19:25

Revert idlelib/todo.txt

b02137c

I don't want this changed unless backported to 3.7, 3.6. Code changes probably will not be.

terryjreedy requested changes Sep 15, 2018

View reviewed changes

bedevere-bot added awaiting changes and removed awaiting review labels Sep 15, 2018

terryjreedy closed this Sep 16, 2018

python locked as too heated and limited conversation to collaborators Sep 17, 2018

Uh oh!

bpo-34660: Replace offensive words #9335

bpo-34660: Replace offensive words #9335

Uh oh!

Conversation

jonsees commented Sep 15, 2018 • edited by bedevere-bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

the-knights-who-say-ni commented Sep 15, 2018

Uh oh!

terryjreedy left a comment

Choose a reason for hiding this comment

Uh oh!

terryjreedy Sep 15, 2018

Choose a reason for hiding this comment

Uh oh!

terryjreedy Sep 15, 2018

Choose a reason for hiding this comment

Uh oh!

terryjreedy Sep 15, 2018

Choose a reason for hiding this comment

Uh oh!

terryjreedy Sep 15, 2018

Choose a reason for hiding this comment

Uh oh!

bedevere-bot commented Sep 15, 2018

Uh oh!

suic86 commented Sep 16, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hawran commented Sep 16, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

RaresDima commented Sep 16, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

terryjreedy commented Sep 16, 2018

Uh oh!

willingc commented Sep 17, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

jonsees commented Sep 15, 2018 •

edited by bedevere-bot

Loading

suic86 commented Sep 16, 2018 •

edited

Loading

hawran commented Sep 16, 2018 •

edited

Loading

RaresDima commented Sep 16, 2018 •

edited

Loading

willingc commented Sep 17, 2018 •

edited

Loading