bpo-14156:Add argparse.FileType for a mode of 'rb' and 'wb'#9124
Closed
hongweipeng wants to merge 2 commits intopython:masterfrom
Closed
bpo-14156:Add argparse.FileType for a mode of 'rb' and 'wb'#9124hongweipeng wants to merge 2 commits intopython:masterfrom
hongweipeng wants to merge 2 commits intopython:masterfrom
Conversation
Lib/argparse.py
Outdated
| file = string | ||
| closefd = True | ||
|
|
||
| # all other arguments are used as file names |
Member
There was a problem hiding this comment.
Shouldn't this comment be moved 3 lines above?
| text = text.decode('ascii') | ||
| return self.name == other.name == text | ||
|
|
||
| class FilenoMode(object): |
Member
There was a problem hiding this comment.
Inheriting object is redundant.
Contributor
Author
There was a problem hiding this comment.
It doesn't matter, it is similar to class RFile(object) in the file.
Contributor
Author
There was a problem hiding this comment.
Do I need to modify it?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change patch to a RP.
https://bugs.python.org/issue14156