bpo-34246: Make sure test_smtplib always cleans resources when finished#9108
Merged
Conversation
vstinner
reviewed
Sep 7, 2018
vstinner
left a comment
Member
There was a problem hiding this comment.
The overall change LGTM, but I have a few comments/requests.
Member
There was a problem hiding this comment.
You can use support.join_thread(self.thread) to raise an error if the thread cannot be joined in 30 seconds, rather than being stuck.
Member
Author
There was a problem hiding this comment.
I will change then the rest of thread.joins of this module as there are plenty.
Member
There was a problem hiding this comment.
I suggest to rename the attribute to "self.thread_key".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue34246