Skip to content

[3.6] bpo-34563: Fix for invalid assert on big output of multiprocessing.Process (GH-9027)#9069

Merged
vstinner merged 5 commits into
python:3.6from
ahcub:3.6
Sep 7, 2018
Merged

[3.6] bpo-34563: Fix for invalid assert on big output of multiprocessing.Process (GH-9027)#9069
vstinner merged 5 commits into
python:3.6from
ahcub:3.6

Conversation

@ahcub

@ahcub ahcub commented Sep 5, 2018 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

ahcub added 2 commits September 5, 2018 04:23
@ahcub
[3.6] bpo-34563: Fix for invalid assert on big output of multiprocess…
3eb1eed 
…ing.Process (pythonGH-9027)

Fix for invalid assert on big output of multiprocessing.Process.

(cherry picked from commit 266f490)
@ahcub
remove parts that are not from the multiprocessing fix
893deb2
@bedevere-bot bedevere-bot mentioned this pull request Sep 5, 2018
Merged
@tirkarthi

tirkarthi commented Sep 5, 2018

Copy link
Copy Markdown
Member

Just as an update Appveyor build failure is tracked here : https://bugs.python.org/issue34575

Thanks

@ahcub

ahcub commented Sep 5, 2018

Copy link
Copy Markdown
Contributor Author

can we trigger something like clean rebuild for AppVeyor?

@tirkarthi

tirkarthi commented Sep 5, 2018

Copy link
Copy Markdown
Member

There is a REST API to clear the cache manually. I have added this at https://bugs.python.org/msg324613 . Maybe someone with credentials can try to see if it helps.

Ref : appveyor/ci#985

Thanks

@vstinner

vstinner commented Sep 5, 2018

Copy link
Copy Markdown
Member

AppVeyor hits https://bugs.python.org/issue34575 bug

@ahcub

ahcub commented Sep 7, 2018

Copy link
Copy Markdown
Contributor Author

is there anything I can do to help to get this PR merged?

@tirkarthi

tirkarthi commented Sep 7, 2018 •
edited
Loading

Copy link
Copy Markdown
Member

VS2017 that was causing build failure was removed as per the linked issue for Python 3.6 in Appveyor. Since it's a backport I think a rebuild trigger by someone with access will work fine.

Thanks

@vstinner vstinner merged commit 23f427a into python:3.6 Sep 7, 2018
@vstinner

vstinner commented Sep 7, 2018

Copy link
Copy Markdown
Member

The AppVeyor is currently not mandatory. I'm quite sure that the fix is good, and we have post-commit tests using buildbots on 3.6, so I merged your PR.

@ahcub

ahcub commented Sep 7, 2018 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

awesome, thank you so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ahcub @tirkarthi @vstinner @the-knights-who-say-ni @bedevere-bot