bpo-28166: Continue to read after Ctrl+C if SIGINT was ignored#8344
bpo-28166: Continue to read after Ctrl+C if SIGINT was ignored#8344ValeriyaSinevich wants to merge 15 commits into
Conversation
|
@ValeriyaSinevich The whitespace issue seems to be because of using tabs instead of spaces (which for some unknown reason VS still defaults to for C++...). Replacing them with spaces (and ensuring indents of 4 spaces, which doesn't seem to be consistent in the existing code) should get you past that check. |
csabella
left a comment
There was a problem hiding this comment.
@ValeriyaSinevich, please address @zooba's comments about the whitespace in order to pass the CI checks. Thanks!
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
|
The original author of this pull request doesn't seem to be active anymore, so I'm going to close this PR. It can be reopened or a new pull request can be created to address the issue. Thank you! |
Do not break out of the reading loop if SIGINT was ignored or the handler doesn't raise an exception.
https://bugs.python.org/issue28166