bpo-33265: use an actual method instead of a method-like function in ExitStack#6456
Merged
ncoghlan merged 1 commit intopython:masterfrom Apr 13, 2018
Merged
Conversation
f525c31 to
478d17c
Compare
Contributor
|
Changes to implementation details still get Skipping the |
ncoghlan
approved these changes
Apr 12, 2018
Contributor
ncoghlan
left a comment
There was a problem hiding this comment.
+1 from me for the actual change - I think the only reason I didn't do it this way originally is because it didn't occur to me.
1st1
approved these changes
Apr 13, 2018
Member
|
lgtm! |
478d17c to
a31ba53
Compare
Contributor
Author
OK, news added. |
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue33265