Conversation
Contributor
Author
|
The AppVeyor failure is unrelated: |
Note: this doesn't unpack f-strings into the underlying JOINEDSTR AST.
Member
|
See my comments on http://bugs.python.org/issue23894. In particular, shouldn't there be some tests? Also, please do not push new branches directly to the python/cpython repo. The process as documented is to push proposed changes to your own fork and then make a PR from your fork to python/cpython. See http://cpython-devguide.readthedocs.io/committing.html#working-with-git. |
Contributor
Author
|
Alright, agreed this should wait for 3.6.2. In the mean time, I'll add tests. I'm on the fence whether it's worth splitting f'' into separate tokens in lib2to3. It'd make the change more invasive. |
Contributor
Author
|
I'll reopen a fresh PR from my own clone. |
|
@ambv any update on this? |
Contributor
Author
|
@Daenyth, done, will be part of 3.6.2. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: this doesn't unpack f-strings into the underlying JOINEDSTR AST.
Ideally we'd fully implement JOINEDSTR here but given limited time for 3.6.1 I think this is worth bandaiding as is. This unblocks tools like https://github.com/google/yapf to format 3.6 syntax using f-strings and
rb''.