Skip to content

[3.6] bpo-32667: Fix tests when $PATH contains a file (GH-5322)#5323

Merged
vstinner merged 1 commit intopython:3.6from
miss-islington:backport-b31206a-3.6
Jan 25, 2018
Merged

[3.6] bpo-32667: Fix tests when $PATH contains a file (GH-5322)#5323
vstinner merged 1 commit intopython:3.6from
miss-islington:backport-b31206a-3.6

Conversation

@miss-islington
Copy link
Copy Markdown
Contributor

@miss-islington miss-islington commented Jan 25, 2018

Some tests failed when the PATH environment variable contained a path
to an existing file. Fix tests to ignore also NotADirectoryError, not
only FileNotFoundError and PermissionError.
(cherry picked from commit b31206a)

https://bugs.python.org/issue32667

Some tests failed when the PATH environment variable contained a path
to an existing file. Fix tests to ignore also NotADirectoryError, not
only FileNotFoundError and PermissionError.
(cherry picked from commit b31206a)
Copy link
Copy Markdown
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good bot.

@miss-islington
Copy link
Copy Markdown
Contributor Author

@vstinner: Backport status check is done, and it's a success ✅ .

@vstinner vstinner merged commit 255dbd2 into python:3.6 Jan 25, 2018
@miss-islington
Copy link
Copy Markdown
Contributor Author

Thanks, @vstinner!

@miss-islington miss-islington deleted the backport-b31206a-3.6 branch January 25, 2018 21:39
@vstinner
Copy link
Copy Markdown
Member

You are welcome, darling.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants