bpo-30491: Add unawaited coroutine tracking mode#5279
Closed
njsmith wants to merge 1 commit intopython:mainfrom
Closed
bpo-30491: Add unawaited coroutine tracking mode#5279njsmith wants to merge 1 commit intopython:mainfrom
njsmith wants to merge 1 commit intopython:mainfrom
Conversation
This provides a fast and easy way to get a list of coroutines that have been created, but not awaited. For example, a test harness can use it to reliably check after each test whether it had any missing 'await's (which can otherwise cause spurious test successes).
04c62df to
3954f61
Compare
csabella
reviewed
Jan 25, 2018
|
|
||
| .. function:: set_unawaited_coroutine_tracking_enabled(enabled) | ||
|
|
||
| Enables or disables "unawaited coroutine tracking mode". This is a |
Contributor
There was a problem hiding this comment.
Looks like the sys page uses the command form, so I believe this should be Enable or disable. Same with the other new function descriptions.
| while ((coro = _PyCoro_PopUnawaited())) { | ||
| if (PyList_Append(output, coro) < 0) { | ||
| Py_DECREF(coro); | ||
| return NULL; |
Contributor
There was a problem hiding this comment.
output is leaked here.
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This provides a fast and easy way to get a list of coroutines that
have been created, but not awaited. For example, a test harness can
use it to reliably check after each test whether it had any missing
'await's (which can otherwise cause spurious test successes).
https://bugs.python.org/issue30491